[Webkit-unassigned] [Bug 45808] Add Worker support for FileSystem API

Thu Sep 23 15:56:24 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=45808

David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68610|review?                     |review+
               Flag|                            |

--- Comment #41 from David Levin <levin at chromium.org>  2010-09-23 15:56:24 PST ---
(From update of attachment 68610)
View in context: https://bugs.webkit.org/attachment.cgi?id=68610&action=review

Two trivial suggestions.

> WebCore/workers/WorkerContext.h:157
> +        void registerObserver(Observer* observer);
> +        void unregisterObserver(Observer* observer);

Remove param name "observer".

> WebKit/chromium/src/WorkerFileSystemCallbacksBridge.h:107
> +    // m_selfRef keeps a reference to itself until tasks are created for the worker thread (at which point the tasks hold the reference).

My typo s/tasks/task/

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.