[Webkit-unassigned] [Bug 10687] object embedded in HTML: default background should be transparent.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=10687


Dave Hyatt <hyatt at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68511|review?                     |review-
               Flag|                            |




--- Comment #35 from Dave Hyatt <hyatt at apple.com>  2010-09-23 10:28:46 PST ---
(From update of attachment 68511)
View in context: https://bugs.webkit.org/attachment.cgi?id=68511&action=review

> WebCore/dom/Document.cpp:2171
> +#endif

I don't think you need to cache this information.  Asking if the documentElement() has the SVG tag name every time is fine.  It's a quick check (it's AtomicString comparisons, which are very fast).

If you do still want to cache it, a better place would be in cacheDocumentElement().

> WebCore/dom/Document.h:388
> +    virtual bool hasSVGRootNode() const { return m_hasSVGRootNode; }

I don't think this needs to be virtual, since the same check that works for non-SVG documents (checking the root node) should also work for SVG documents.  It's faster to just do the root node tag check than it is to call a virtual function.

> WebCore/svg/SVGDocument.h:55
> +        virtual bool hasSVGRootNode() const { return true; }

Just remove this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.