[Webkit-unassigned] [Bug 44700] IDBObjectStore::get should run in a transaction.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44700


Jeremy Orlow <jorlow at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68476|review?                     |review-
               Flag|                            |




--- Comment #26 from Jeremy Orlow <jorlow at chromium.org>  2010-09-23 04:09:05 PST ---
(From update of attachment 68476)
View in context: https://bugs.webkit.org/attachment.cgi?id=68476&action=review

few comments until you can get me the re-based version with the test changes....close tho

> WebCore/storage/IDBObjectStoreBackendImpl.h:76
> +    template <class T, class Method, class Param1, class Param2>

Could this stuff just all go in the .cpp?

> WebCore/storage/IDBTransactionCoordinator.h:70
> +    HashMap<int, RefPtr<IDBTransactionBackendImpl> > m_transactions;

This is a little be weird, but probably cleaner than anything else I can think of (like having transactions self ref).

> WebCore/storage/IDBTransactionCoordinator.h:72
> +    HashSet<IDBTransactionBackendImpl*> m_pendingTransactions;

Is this still necessary?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.