[Webkit-unassigned] [Bug 27165] Connections-per-host should be tracked closer to the ResourceHandle level, not the Cache

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27165





--- Comment #20 from Antti Koivisto <koivisto at iki.fi>  2010-09-23 03:16:54 PST ---
Reading the comments above, it was clearly known that this is patch could change behavior in poorly understood ways. That's not good, especially for refactoring patches.

> That diagram is missing a lot of details and certainly still up for discussion.  Our thought process is to try to improve the loader iteratively.  This patch is one step in that direction.  Of course, the loader is complicated, so we're try to proceed slowly and carefully.  Input from folks such as yourself is much appreciated.

The design looks good as far as pictures of boxes go, though obviously it doesn't really capture the real complexity of the loading subsystem.

I think this patch could be fixed by reverting the changes to Loader, expect for those that are directly related to moving counting of connections to the new class. The OpenConnectionLimiter should probably also signal Loader when there are more slots available (this is currently achieved by calling Loader::nonCacheRequestComplete() from random places).

Still, I'm not sure that keeping per-host data in two places (Loader::Host map for queues, OpenConnectionLimiter for the count) instead of one is an improvement. Perhaps we should move most of the Loader::Host to the ResourceLoader level instead?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.