[Webkit-unassigned] [Bug 45808] Add Worker support for FileSystem API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45808





--- Comment #36 from David Levin <levin at chromium.org>  2010-09-22 21:53:21 PST ---
(From update of attachment 68467)
View in context: https://bugs.webkit.org/attachment.cgi?id=68467&action=review


One more important change:

> WebCore/workers/WorkerContext.cpp:407
> +        (*iter)->notifyStop();
> +        (*iter)->stopObserving();

(I know I wrote this code but) It isn't quite correct. notifyStop may result in the object being deleted in which case calling stopObserving is really bad.

Instead I would suggest
  WorkerContext::Observer* observer = *iter;
  m_workerObservers.remove(iter); // It is ok to remove the observer directly because unregisterObserver is ok with the observer not being in m_workerObservers.
  observer->notifyStop();

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.