[Webkit-unassigned] [Bug 23351] Add preference to not select when right-clicked

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23351


Antonio Gomes <tonikitoo at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68460|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #11 from Antonio Gomes <tonikitoo at webkit.org>  2010-09-22 18:59:43 PST ---
(From update of attachment 68460)
View in context: https://bugs.webkit.org/attachment.cgi?id=68460&action=review

> WebCore/page/EventHandler.cpp:2010
> +    if (m_frame->editor()->behavior().shouldSelectOnContextualMenuClick()
> +        && !m_frame->selection()->contains(viewportPos)

Although I know your intention with this fix and I agree, as it is now you are going to regress Gtk, since it sets the Mac editing behavior.

See from webkitwebsettings.cpp:
(...)
 670     /**
 671     * WebKitWebSettings:editing-behavior
 672     *
 673     * This setting controls various editing behaviors that differ
 674     * between platforms and that have been combined in two groups,
 675     * 'Mac' and 'Windows'. Some examples:
 676     * 
 677     *  1) Clicking below the last line of an editable area puts the
 678     * caret at the end of the last line on Mac, but in the middle of
 679     * the last line on Windows.
 680     *
 681     *  2) Pushing down the arrow key on the last line puts the caret
 682     *  at the end of the last line on Mac, but does nothing on
 683     *  Windows. A similar case exists on the top line.
 684     *
 685     * Since: 1.1.13
 686     */
 687     g_object_class_install_property(gobject_class,
 688                                     PROP_EDITING_BEHAVIOR,
 689                                     g_param_spec_enum("editing-behavior",
 690                                                       _("Editing behavior"),
 691                                                       _("The behavior mode to use in editing mode"),
 692                                                       WEBKIT_TYPE_EDITING_BEHAVIOR,
 693                                                       WEBKIT_EDITING_BEHAVIOR_MAC,
 694                                                       flags));

So we really need a 'linux' behavior here. Could you please wait me to fix bug 36627 (I have time to work on that now)?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.