[Webkit-unassigned] [Bug 25898] [Gtk] object:text-changed events should be emitted for entries and password text

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25898


Mario Sanchez Prada <msanchez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68346|0                           |1
        is obsolete|                            |
  Attachment #68427|                            |review?, commit-queue?
               Flag|                            |




--- Comment #92 from Mario Sanchez Prada <msanchez at igalia.com>  2010-09-22 13:18:57 PST ---
Created an attachment (id=68427)
 --> (https://bugs.webkit.org/attachment.cgi?id=68427)
Single patch for fixing this bug + Unit test

(In reply to comment #91)
> (From update of attachment 68346 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=68346&action=review
> 
> On further consideration, I'm pretty nervous that this does not hava test attached to it? Is it possible to write one?

Attaching a new patch with a new unit case in testatk.c to check this works as expected.

> > WebCore/accessibility/gtk/AXObjectCacheAtk.cpp:73
> > +    GOwnPtr<gchar> detail;
> > +    switch (textChange) {
> > +    case AXObjectCache::AXTextInserted:
> > +        detail.set(g_strdup("text-changed::insert"));
> > +        break;
> > +    case AXObjectCache::AXTextDeleted:
> > +        detail.set(g_strdup("text-changed::delete"));
> > +        break;
> > +    }
> 
> Please use CString here. Sorry I didn't notice this before.

No problem. Done.

Let's see this time... :-)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.