[Webkit-unassigned] [Bug 45589] Inline UTF8SequenceLength

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45589





--- Comment #11 from Darin Adler <darin at apple.com>  2010-09-22 09:45:33 PST ---
(In reply to comment #10)
> (In reply to comment #9)
> > Sorry to keep pushing on this, but did you try just calling the inline version as-is rather than merging them? I’d expect an even-better speed improvement if you just changed the call site in convertUTF8ToUTF16 and didn’t make the other changes.
> I don't know why, but you're right! It's faster with the newest patch.

I believe I wrote the original function, and I followed the principle of inlining the hot part of the code and keeping the less-hot part out of line. This often makes things faster than just inlining everything.

Seeing that your original patch reversed that decision, I asked you to measure. Thanks for the extra effort.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.