[Webkit-unassigned] [Bug 46086] Web Inspector: implement pausing on XHR

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46086


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68359|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #11 from Pavel Feldman <pfeldman at chromium.org>  2010-09-22 05:40:44 PST ---
(From update of attachment 68359)
View in context: https://bugs.webkit.org/attachment.cgi?id=68359&action=review

> WebCore/bindings/v8/custom/V8XMLHttpRequestCustom.cpp:117
> +    InspectorController::instrumentWillSendXMLHttpRequest(xmlHttpRequest->scriptExecutionContext(), xmlHttpRequest->url());

Please guard this with #ifdef

> WebCore/inspector/Inspector.idl:140
> +        [handler=Controller] void setNativeBreakpoint(in unsigned int type, in Object breakpoint, out unsigned int breakpointId);

It is unclear how to specify 'breakpoint' parameter format. Why does it have url property? Should we merge 'type' into 'breakpoint' instead? Like

breakpoint: { type: "XHR", condition: { url : "foo" } }

> WebCore/inspector/InspectorController.h:492
> +    ASSERT(document);

Counter?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.