[Webkit-unassigned] [Bug 46165] Focused frame information needed in Chrome and ChromeClient

Tue Sep 21 23:06:14 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=46165

--- Comment #4 from Juha Savolainen <juha.savolainen at weego.fi>  2010-09-21 23:06:14 PST ---
(In reply to comment #2)
> I think the patch is straightforward and reasonable. Question:
> 
> 1) Do we need this for WebKit1 too?

Well, I think no. This notification was added because of WebKit2 architecture(UIProcess/WebProcess). In WebKit1 it is quite simply to ask focused frame from WebCore and return that to the user immeadiately. Ofcourse this could be also used in WebKit1 but I think  that there isn't such benefit than in WebKit2.

> 2) Should the various ChromeClient in WebKit/ get updated?

My idea is that this only affect to WebKit2-side.

> 3) Should we pass the Focused frame as parameter?

Maybe not. We only need to resolve WebKit2::WebFrame.frameID which is focused. Also a little bit later I will introduce WebPage::currentFrameID() method in WebKit2 which returns ID of focused WebFrame. Because this method dosen't take parameter WebKit::Frame* this could be used allways to resolve focused framedID, even if we don't know which WebKit::Frame is currently activated. In our case, when focused frame has changed and FocusController calls WebChromeClient::focusedFrameChanged() we just call currentFrameID() method and send frameID to UIProcess.

> 4) Can we test that somehow? even if it is an autotest ... (of course layout test preferred)

Cannot answer right now, I need investigate testing a little bit more how this kind of functions is tested earlyer.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.