[Webkit-unassigned] [Bug 46099] check-webkit-style and the coding style guidelines page are inconsistent

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 21 17:45:25 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=46099


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68213|review?                     |review+
               Flag|                            |




--- Comment #8 from Darin Adler <darin at apple.com>  2010-09-21 17:45:24 PST ---
(From update of attachment 68213)
I think it’s fine to make this clearer in this fashion. Ordered as “sort” would do was intended to be ordered as sort would sort the entire source lines, not just the filenames, and so that’s why there’s no separate rule about this today.

If it was me, I would simply add some system header to the existing example instead of making this a separate rule, but I’m OK with it like this too.

I don’t think this really requires webkit-dev discussion. This rule has not changed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list