[Webkit-unassigned] [Bug 44920] Add layout tests for FileSystem API

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 21 15:06:03 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=44920


chris fleizach <cfleizach at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67987|review?                     |review-
               Flag|                            |




--- Comment #7 from chris fleizach <cfleizach at apple.com>  2010-09-21 15:06:03 PST ---
(From update of attachment 67987)
View in context: https://bugs.webkit.org/attachment.cgi?id=67987&action=review

All the results generally look like "8" is "8"... can these have a little more context in them. right now they're impossible for a human to parse

tests should be as such

shouldBe("controller.operation.result", "true");

so the results are understandable when something breaks

> LayoutTests/fast/filesystem/script-tests/simple-persistent.js:13
> +    shouldBeTrue("true");

this looks meaningless

> LayoutTests/fast/filesystem/simple-temporary-expected.txt:7
> +WARN: shouldBe() expects string arguments

this looks wrong

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list