[Webkit-unassigned] [Bug 43400] Add priority attribute to XMLHttpRequest

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 21 13:48:16 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=43400





--- Comment #27 from James Simonsen <simonjam+webkit at google.com>  2010-09-21 13:48:15 PST ---
Sorry for the extremely slow turnaround. I've addressed all of your comments.

(In reply to comment #25)
> (From update of attachment 63779 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=63779&action=prettypatch
> > WebCore/xml/XMLHttpRequest.cpp:413
> > +    for (int i = 0; i < 5; ++i) {
> The magic constant 5 seems quite decoupled from the size of the array.  Do we have an arraysize macro in this code?  Failing that, a global constant used in place of each instance of 5 would be preferable.

I used sizeof(array)/sizeof(array[0]) and stored that in a global constant. This seems to be the common way for WebKit code to determine array size.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list