[Webkit-unassigned] [Bug 46192] Add link to bug to review page

Tue Sep 21 12:32:58 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=46192

--- Comment #3 from Darin Adler <darin at apple.com>  2010-09-21 12:32:58 PST ---
(In reply to comment #1)
> 1) Adding the link at a time when we know the bug_id.  We know the bug_id in the context of this function:
> http://trac.webkit.org/browser/trunk/BugsSite/code-review.js#L225

Now that I know about this it won’t be too hard.

> 2) Deciding where to display the link.  I think putting it on the toolbar makes sense, but the toolbar is getting a bit crowded.  Maybe we should move the help text elsewhere?
> 
> 3) The CSS for hyperlinks in PrettyPatch is overbroad, which means it would apply to the bug link too.  We probably need to tighten down the CSS for hyperlinks so the bug link isn't the wrong font/size.

When doing the work myself, I used the web inspector to insert the link and it looked fine. For both (2) and (3) above, it was OK the way I had it. I figured others might later want to refine further, but I think just putting the bug before the instructions is fine. And the style for links looked OK to me.

Assuming it’s a Chromium extension, I’ll have to make it work in Safari, but thanks very much for showing me that extension.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.