[Webkit-unassigned] [Bug 25898] [Gtk] object:text-changed events should be emitted for entries and password text

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25898


Mario Sanchez Prada <msanchez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68201|0                           |1
        is obsolete|                            |
  Attachment #68263|                            |review?, commit-queue?
               Flag|                            |




--- Comment #86 from Mario Sanchez Prada <msanchez at igalia.com>  2010-09-21 11:05:56 PST ---
Created an attachment (id=68263)
 --> (https://bugs.webkit.org/attachment.cgi?id=68263)
Single patch for fixing this bug

(In reply to comment #85)
> (From update of attachment 68201 [details])
> Rejecting patch 68201 from commit-queue.
> 
[...]
> 
> Full output: http://queues.webkit.org/results/4097013

I'm definitely doomed with this patch...

Looks the error is this: 

In file included from /Users/abarth/git/webkit-queue/WebKit/mac/WebView/WebFrame.mm:56:
/Users/abarth/git/webkit-queue/WebKitBuild/Debug/WebCore.framework/PrivateHeaders/AXObjectCache.h:29:39: error: AccessibilityRenderObject.h: No such file or directory
In file included from /Users/abarth/git/webkit-queue/WebKit/mac/WebView/WebFrame.mm:56:
[...]

And I bet it's because of this part of my patch:

--- a/WebCore/accessibility/AXObjectCache.h
+++ b/WebCore/accessibility/AXObjectCache.h
@@ -26,7 +26,7 @@
 #ifndef AXObjectCache_h
 #define AXObjectCache_h

-#include "AccessibilityObject.h"
+#include "AccessibilityRenderObject.h"
[...]


I think it was a mistake (my mistake) to remove #include "AccessibilityObject.h", even if it was ok to compile it in my local machine, and that's what is causing all that mess in the WebKit/mac/WebView/WebFrame.mm.

Now attaching a new patch that does not remove that line, and just adds "AccessibilityRenderObject.h" instead.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.