[Webkit-unassigned] [Bug 45718] WebGL's readPixels doesn't respect origin-clean flag

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45718





--- Comment #8 from Zhenyao Mo <zmo at google.com>  2010-09-21 10:59:05 PST ---
(From update of attachment 68191)
View in context: https://bugs.webkit.org/attachment.cgi?id=68191&action=review

Overall looks good with some minor issues.  See the comments between the lines.

About the test, here is an example you can have a look: "WebKit/LayoutTests/http/tests/xmlhttprequest/access-control-basic-denied.html".  It uses http://localhost:8000 for cross-domain access.  Also, in the khronos test, the video path is not tested.  Maybe it's time to finish that TODO task together with this patch.

> WebCore/html/canvas/CanvasRenderingContext.cpp:56
> +    if (canvas()->originClean() && pattern && pattern->originClean())

should be !patter->originClean()

> WebCore/html/canvas/CanvasRenderingContext.cpp:62
> +    if (canvas()->originClean() && !sourceCanvas->originClean())

should also check sourceCanvas is not null like you did with pattern.

> WebCore/html/canvas/CanvasRenderingContext.cpp:80
> +    if (canvas()->originClean() && video && !video->hasSingleSecurityOrigin())

The original video code path performs checkOrigin(video->currentSrc()).  Is there any reason you don't perform this anymore?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.