[Webkit-unassigned] [Bug 46086] Web Inspector: implement pausing on XHR

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46086


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68249|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #7 from Pavel Feldman <pfeldman at chromium.org>  2010-09-21 09:45:44 PST ---
(From update of attachment 68249)
View in context: https://bugs.webkit.org/attachment.cgi?id=68249&action=review

> WebCore/inspector/InspectorController.cpp:2137
> +#if ENABLE(JAVASCRIPT_DEBUGGER)

I think you should inline willSendXHR here.

> WebCore/inspector/InspectorController.h:483
> +inline InspectorController* InspectorController::inspectorControllerForDocument(Document* document)

Can we employ static InspectorController counter here to speed up things?

> WebCore/inspector/InspectorDebuggerAgent.h:48
> +enum DebuggerEvent {

NativeBreakpointType ?

> WebCore/inspector/InspectorDebuggerAgent.h:83
> +    void willSendXHR(const String& url);

willSendXHR does not look good as a part of debugger agent.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.