[Webkit-unassigned] [Bug 43988] Web Inspector: Remote Web Inspector support for QtWebKit

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=43988





--- Comment #23 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2010-09-21 07:30:17 PST ---
(From update of attachment 67549)
View in context: https://bugs.webkit.org/attachment.cgi?id=67549&action=review

> WebKit/qt/WebCoreSupport/InspectorServerQt.cpp:67
> +/*
> + * Parses and returns a WebSocket challenge number according to the method specified in the WebSocket protocol.
> + *
> + * The field contains numeric digits interspersed with spaces and
> + * non-numeric digits. The protocol ignores the characters that are
> + * neither digits nor spaces. The digits are concatenated and
> + * interpreted as a long int. The result is this number divided by the
> + * number of spaces.
> + */

We don't add * per line. Look at our other comments.

> WebKit/qt/WebCoreSupport/InspectorServerQt.cpp:75
> +            nSpaces++;

numSpaces?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.