[Webkit-unassigned] [Bug 46099] check-webkit-style and the coding style guidelines page are inconsistent

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46099





--- Comment #3 from Csaba Osztrogonac <ossy at webkit.org>  2010-09-20 23:46:57 PST ---
(From update of attachment 68098)
View in context: https://bugs.webkit.org/attachment.cgi?id=68098&action=review

I have never seen "system style" and "normal style" includes in C terminology,
but system headers. See: http://gcc.gnu.org/onlinedocs/cpp/Include-Syntax.html#Include-Syntax

Otherwise LGTM, making clear this style issue is necessary.

> WebKitSite/ChangeLog:9
> +        * coding/coding-style.html: Making clear that system style includes
> +        should not come before normal ones.

I prefer like this:
Making clear that includes of system headers must come after includes of other headers.

> WebKitSite/coding/coding-style.html:759
> +<li>System syle includes should not come before normal ones.

I prefer like this:
Includes of system headers must come after includes of other headers.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.