[Webkit-unassigned] [Bug 40275] [BREWMP] Port graphics backend

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40275





--- Comment #10 from Kwang Yul Seo <kwangyul.seo at gmail.com>  2010-09-20 17:42:41 PST ---
(In reply to comment #6)
> Since Brew MP has no builders on build.webkit.org, what's the plan if changes to this file break that port?
> 
> Also, what OS setting does Brew MP set?  I don't know anything about it as a platform.  Maybe it's simpler for Brew to just set OS(LINUX)?  It's kind of weird to mix up OS() and PLATFORM() #ifdefs in a single expression.

Another way to clean up the code is to split OS(WINDOWS) and OS(LINUX) into separate files and move OS(WINDOWS) part to platform/graphics/chromium and leave OS(LINUX) part in platform/graphics/skia without guards. 

I think OS(WINDOWS) part of FontCustomPlatformData.cpp/h is still Chromium-specific while OS(LINUX) part depends only on skia.

After this cleanup, Brew MP can use FontCustomPlatformData in platform/graphics/skia without modification.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.