[Webkit-unassigned] [Bug 44700] IDBObjectStore::get should run in a transaction.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44700





--- Comment #14 from Andrei Popescu <andreip at google.com>  2010-09-20 16:41:39 PST ---
All fixed, except for the below:

(In reply to comment #12)
> > WebCore/storage/IDBObjectStore.cpp:70
> >      return request;
> 
> .release()
>

Why release? The object store is associated with this transaction and other operations may follow.

> > WebCore/storage/IDBObjectStoreBackendImpl.cpp:84
> > +    if (transaction) {
> 
> Would this ever not be true?
> 


Yes, we use this to differentiate between the method being called by the object store or by the transaction.

> > WebCore/storage/IDBTransaction.cpp:70
> > +        throwError(NOT_SUPPORTED_ERR);
> 
> Do you need to add the string for this error somewhere?
>

I don't think so, it's a standard exception.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.