[Webkit-unassigned] [Bug 45863] Add HRTFKernel files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45863


James Robinson <jamesr at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67936|review?                     |review+
               Flag|                            |




--- Comment #10 from James Robinson <jamesr at chromium.org>  2010-09-20 14:15:41 PST ---
(From update of attachment 67936)
Looks good! Just some nits, feel free to address while landing or post a new patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=67936&action=prettypatch

> WebCore/platform/audio/HRTFKernel.cpp:124
> +    bool checkX = x >= 0.0 && x < 1.0;
> +    ASSERT(checkX);

nit: better to put the predicate directly into the ASSERT()

> WebCore/platform/audio/HRTFKernel.cpp:126
> +    x = max(0.0, x);
> +    x = min(1.0, x);

nit: could be one expression

> WebCore/platform/audio/HRTFKernel.h:67
> +    

nit: extra newline

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.