[Webkit-unassigned] [Bug 46028] [FileSystem] Fix Flags handling in DirectoryEntry custom binding code

Mon Sep 20 13:52:06 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=46028

Dumitru Daniliuc <dumi at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67997|review?                     |review+
               Flag|                            |

--- Comment #2 from Dumitru Daniliuc <dumi at chromium.org>  2010-09-20 13:52:06 PST ---
(From update of attachment 67997)
r=me.

toFlags() returns a ref-counted object, because WebCore::Flags is ref-counted, right? if this is correct, it might be nice to mention this in the ChangeLog file (to make sure we don't copy-paste this code for some other class, and automatically assume that toNewClass() will be ref-counted too, when it might not be).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.