[Webkit-unassigned] [Bug 45942] [GTK] fast/forms/listbox-selection.html fails

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45942





--- Comment #4 from Martin Robinson <mrobinson at webkit.org>  2010-09-20 10:43:25 PST ---
(In reply to comment #3)
> (In reply to comment #2)
> > I did a brief search for all layout tests that call eventSender.keyDown() with a non-empty list of modifiers that are also in the GTK Skipped list and found fast/events/keydown-1.html. Does this still fail?
> 
> This one just needed platform-specific results. I've added them.
> 
> > I noticed that you did not put a similar comment "// Get the modifiers from the second argument." above the other call sites in mouseUpCallback and mouseDownCallback. We may want to consider putting such a comment at these other call sites.
> 
> I just removed this comment. After further consideration it really answers "What?" instead of "Why?" It's superfluous, I think.

By the way, thanks for the awesome review!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.