[Webkit-unassigned] [Bug 25898] [Gtk] object:text-changed events should be emitted for entries and password text

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25898


Mario Sanchez Prada <msanchez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67463|0                           |1
        is obsolete|                            |
  Attachment #67463|review?                     |
               Flag|                            |
  Attachment #68105|                            |review?, commit-queue?
               Flag|                            |




--- Comment #79 from Mario Sanchez Prada <msanchez at igalia.com>  2010-09-20 10:16:19 PST ---
Created an attachment (id=68105)
 --> (https://bugs.webkit.org/attachment.cgi?id=68105)
Single patch for fixing this bug

(In reply to comment #78)
> (From update of attachment 67463 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=67463&action=prettypatch
> 
> > WebCore/accessibility/gtk/AXObjectCacheAtk.cpp:78
> > +    gchar* detailStr = detail.get();
> > +    if (detailStr)
> > +        g_signal_emit_by_name(wrapper, detailStr, offset, count);
> > +}
> 
> This is unnecessary, because GOwnPtr has a implicit bool cast.
> if (detail)
>     g_signal_emit_by_name(wrapper, detail.get(), offset, count);

Fixed

> > WebCore/editing/AppendNodeCommand.cpp:51
> > +    if (nodeValue != "\n")
> 
> I think this should be an early return.
> 

Done

> This look good otherwise, but I'd be more comfortable if someone more familiar with a11y reviewed the platform-independent parts.

I'm attaching a new patch now, asking for review over it, which I guess should be pretty straightforward since now it looks now both Chris and Enrica are ok with the changes in the a11y code and the text editing part, respectively (Besides, I guess both Eric and you will be ok with the current patch, after addressing the issues pointed by you two as well)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.