[Webkit-unassigned] [Bug 46099] New: check-webkit-style and the coding style guidelines page are inconsistent

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46099

           Summary: check-webkit-style and the coding style guidelines
                    page are inconsistent
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: kbalazs at webkit.org


The code style guideline page says: 
"Other #include statements should be in sorted order (case sensitive, as done by the
command-line sort tool or the Xcode sort selection command)".
According to that an ordering is ok if sort do not reorders it.

This one is ordered as sort would do:
------------------------
#include "Chrome.h"
#include "ChromeClientQt.h"
#include <IntSize.h>
#include "NotImplemented.h"
#include <Page.h>
------------------------

check-webkit-style does not accept this. It accepts the following:
------------------------
#include "Chrome.h"
#include "ChromeClientQt.h"
#include "NotImplemented.h"

#include <IntSize.h>
#include <Page.h>
------------------------

I agree that we should separate the system style includes from the normal ones but we should
make it clear in the style guidelines.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.