[Webkit-unassigned] [Bug 25898] [Gtk] object:text-changed events should be emitted for entries and password text

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25898





--- Comment #78 from Martin Robinson <mrobinson at webkit.org>  2010-09-20 08:18:00 PST ---
(From update of attachment 67463)
View in context: https://bugs.webkit.org/attachment.cgi?id=67463&action=prettypatch

> WebCore/accessibility/gtk/AXObjectCacheAtk.cpp:78
> +    gchar* detailStr = detail.get();
> +    if (detailStr)
> +        g_signal_emit_by_name(wrapper, detailStr, offset, count);
> +}

This is unnecessary, because GOwnPtr has a implicit bool cast.
if (detail)
    g_signal_emit_by_name(wrapper, detail.get(), offset, count);

> WebCore/editing/AppendNodeCommand.cpp:51
> +    if (nodeValue != "\n")

I think this should be an early return.


This look good otherwise, but I'd be more comfortable if someone more familiar with a11y reviewed the platform-independent parts.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.