[Webkit-unassigned] [Bug 45857] PluginStrategy should satisfy the needs of Qt

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45857





--- Comment #8 from Balazs Kelemen <kbalazs at webkit.org>  2010-09-20 01:44:22 PST ---
(In reply to comment #7)
> (From update of attachment 67780 [details])
> > +        * plugins/PluginStrategy.h: Added a |const Page*| argument to initPlugins.
> Typo: you're adding the argument to getPluginInfo, not initPlugins.
> 
> This approach looks good to me, it fixes the current crashiness and API regression.
> 
> Why does the Qt part needs to be in a separate patch?

For easier review :). My imagination was that this will be reviewed by a core developer from Apple and the qt part will be reviewed by a Qt folk. Furthermore,
as I know the policy is to keep patches as small as we can.
Actually, the Qt part is out-of-date by means of http://trac.webkit.org/changeset/67787. I think we should land this first and then fix our PlatformStrategies.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.