[Webkit-unassigned] [Bug 12073] Implement setCurrentTime() and pauseAnimations() on SVGSVGElement

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=12073


Nikolas Zimmermann <zimmermann at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67423|review?                     |review-
               Flag|                            |




--- Comment #7 from Nikolas Zimmermann <zimmermann at kde.org>  2010-09-19 07:09:32 PST ---
(From update of attachment 67423)
Hi Chris,

> +void SMILTimeContainer::setElapsed(SMILTime time)
> +{
> +    m_beginTime = currentTime() - time.value();
> +    m_accumulatedPauseTime = 0;
> +    if (isPaused()) {
> +        SMILTime elapsed = this->elapsed();
> +        updateAnimations(elapsed);
> +    }
No need for a local variable, just use:
if (isPaused())
    updateAnimations(elapsed());

You have to write tests and a ChangeLog, please use prepare-ChangeLog in your root WebKit directory to generate templates. r-, until these issues are resolved. The patch itself looks just fine, but you'll need to write several testcases, ideally using the existing framework in LayoutTests/svg/animations.
Test it using accumulative animations, normal ones, etc.

Thanks in advance!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.