[Webkit-unassigned] [Bug 42317] Pasteboard doesn't work in WebKit2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Sep 18 16:58:49 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=42317


Sam Weinig <sam at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67975|review?                     |review+
               Flag|                            |




--- Comment #11 from Sam Weinig <sam at webkit.org>  2010-09-18 16:58:49 PST ---
(From update of attachment 67975)
View in context: https://bugs.webkit.org/attachment.cgi?id=67975&action=prettypatch

> WebCore/loader/EmptyClients.h:438
> +    virtual DocumentFragment* documentFragmentFromAttributedString(NSAttributedString*, Vector< RefPtr<ArchiveResource> >&) { return 0; };

No space before the RefPtr is needed.

> WebCore/page/EditorClient.h:156
> +    virtual DocumentFragment* documentFragmentFromAttributedString(NSAttributedString*, Vector< RefPtr<ArchiveResource> >&) = 0;

Here too.

> WebCore/platform/mac/PasteboardMac.mm:410
> +    Vector< RefPtr<ArchiveResource> > resources;

And here.

> WebKit2/WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:84
> +DocumentFragment* WebEditorClient::documentFragmentFromAttributedString(NSAttributedString *string, Vector< RefPtr<ArchiveResource> >& resources)
> +{

And here.

> WebKit/mac/WebCoreSupport/WebEditorClient.mm:362
> +DocumentFragment* WebEditorClient::documentFragmentFromAttributedString(NSAttributedString *string, Vector< RefPtr<ArchiveResource> >& resources)
>  {

And here,


Otherwise, r=me.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list