[Webkit-unassigned] [Bug 45959] String.prototype.replace passes undefined rather than empty string for groups that don't match

Sat Sep 18 01:22:33 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=45959

Mark Hahnenberg <mhahnenb at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68002|                            |review?
               Flag|                            |

--- Comment #2 from Mark Hahnenberg <mhahnenb at gmail.com>  2010-09-18 01:22:33 PST ---
Created an attachment (id=68002)
 --> (https://bugs.webkit.org/attachment.cgi?id=68002)
Proposed patch

This seemed like a good starter bug for a new contributor such as myself.  I wasn't sure if I needed to add a regression test and if so, where to put it.  As far as the patch goes, I just replaced the jsUndefined() call with an empty string retrieved from the JSGlobalData object.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.