[Webkit-unassigned] [Bug 46021] Add NoStaticTables attributes to IDLs of FileSystem API for Worker support
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Sep 17 18:05:00 PDT 2010
https://bugs.webkit.org/show_bug.cgi?id=46021
--- Comment #4 from Kinuko Yasuda <kinuko at chromium.org> 2010-09-17 18:05:00 PST ---
(In reply to comment #2)
> (From update of attachment 67980 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=67980&action=prettypatch
>
> Mostly looks good. I had a few question about things that I like to understand before r+'ing. (If anyone else understands them and wants to r+, that is fine with me.)
>
> > WebCore/ChangeLog:8
> > + Also changed their module from storage to fileapi.
>
> Why?
I dropped this change (again) from this patch as it might be irrelevant.
(I moved them from WebCore/storage to WebCore/fileapi in r66586 but haven't changed the module name, and I thought it might be better to change the module name too.)
> > WebCore/ChangeLog:17
> > + * fileapi/ErrorCallback.idl:
>
> A few of these idl's including this one didn't get NoStaticTables added to them. Why? (A ChangeLog comment on these file would be nice to explain it.)
Added a comment in ChangeLog - Callback interfaces are implemented differently and NoStaticTables has no effect on them. (That's my understanding - no other callbacks idl seem to have NoStaticTables.)
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list