[Webkit-unassigned] [Bug 45942] [GTK] fast/forms/listbox-selection.html fails

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45942


Daniel Bates <dbates at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67877|review?                     |review+
               Flag|                            |




--- Comment #2 from Daniel Bates <dbates at webkit.org>  2010-09-17 14:57:40 PST ---
(From update of attachment 67877)
View in context: https://bugs.webkit.org/attachment.cgi?id=67877&action=prettypatch

This patch looks sane to me.

r=me

> LayoutTests/platform/gtk/Skipped:-1169
> -fast/forms/listbox-selection.html

I did a brief search for all layout tests that call eventSender.keyDown() with a non-empty list of modifiers that are also in the GTK Skipped list and found fast/events/keydown-1.html. Does this still fail?

> WebKitTools/DumpRenderTree/gtk/EventSender.cpp:463
> +    // Get the modifiers from the second argument.
> +    guint modifiers = argumentCount >= 2 ? gdkModifersFromJSValue(context, arguments[1]) : 0;

I noticed that you did not put a similar comment "// Get the modifiers from the second argument." above the other call sites in mouseUpCallback and mouseDownCallback. We may want to consider putting such a comment at these other call sites.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.