[Webkit-unassigned] [Bug 45808] Add Worker support for FileSystem API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45808





--- Comment #12 from Michael Nordman <michaeln at google.com>  2010-09-17 14:18:49 PST ---
(From update of attachment 67862)
View in context: https://bugs.webkit.org/attachment.cgi?id=67862&action=prettypatch

> WebKit/chromium/src/LocalFileSystemChromium.cpp:70
> +        webWorker->openFileSystem(0, static_cast<WebFileSystem::Type>(type), size, new WebFileSystemCallbacksImpl(new FileSystemCallbacks(successCallback, errorCallback, context)));

is the first '0' arg value stale now that we've removed the 'frame' parameter?

> WebKit/chromium/src/WebWorkerBase.h:95
> +    virtual void openFileSystem(WebFrame*, WebFileSystem::Type, long long size, WebFileSystemCallbacks*);

ah... can we remove the WebFrame* here too?

> WebKit/chromium/src/WebWorkerBase.cpp:338
> +void WebWorkerBase::openFileSystem(WebFrame*, WebFileSystem::Type type, long long size, WebFileSystemCallbacks* callbacks)

and here

> WebKit/chromium/src/WebWorkerClientImpl.h:102
> +    virtual void openFileSystem(WebFrame*, WebFileSystem::Type, long long size, WebFileSystemCallbacks*)

and here

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.