[Webkit-unassigned] [Bug 45864] Add HRTFElevation files

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 17 14:05:52 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=45864





--- Comment #13 from Chris Rogers <crogers at google.com>  2010-09-17 14:05:52 PST ---
James, I think I've addressed your comments except for "Pointers to references?" and am waiting for your opinion on how you would like it changed.

Otherwise, I've created an abstraction function called createBusFromAudioFileResource(const String&),
which given an audio resource name will return the AudioBus for its PCM data.  This removes a lot of the ugliness from this part of my previous patch.

Also, I'm still calling fprintf(stderr, ...) in a few places.  Can you recommend which appropriate LOG() function I should use?

Thanks.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list