[Webkit-unassigned] [Bug 45383] [Gtk] Incorrect exposure of list items whose children are elements

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45383


Mario Sanchez Prada <msanchez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67918|                            |review?
               Flag|                            |




--- Comment #3 from Mario Sanchez Prada <msanchez at igalia.com>  2010-09-17 10:47:24 PST ---
Created an attachment (id=67918)
 --> (https://bugs.webkit.org/attachment.cgi?id=67918)
Patch proposal

After some work I think the most simple way to fix this is by just forcing inclusion in accessibility of the list items in the platform-dependant part of the accessibilityIsIgnored() mechanism, as I found the behaviour of not exposing the list item when its immediate child is a non inline object is the expected behaviour, as coded in AccessibilityRenderObject::accessibilityIsIgnored():

    [...]

    if (m_renderer->isBlockFlow() && m_renderer->childrenInline())
        return !toRenderBlock(m_renderer)->firstLineBox() && !mouseButtonListener();

    [...]

As that part of code is what it's making the difference between a <li>plain text</li> item and a <li><p>paragraph text</p></li> item, I thought the best way to fix this for GTK without bothering other ports was the exposed above.

Then there's an ugly part in the patch that is required to deal with the special case of the list item markers, which are not exposed to AT's but must be taken into account anyway when considering offets and those kind of things.

Hence, now asking for review. Shoot your questions, I'm eager to continue working on this patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.