[Webkit-unassigned] [Bug 45709] Need to remove autocorrection underlines in current line when newline is entered.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45709





--- Comment #11 from jpu at apple.com  2010-09-16 15:45:27 PST ---
(In reply to comment #10)
> (In reply to comment #9)
> > (In reply to comment #8)
> > > Won’t the call in respondToChangedSelection already take care of this? It doesn’t make sense to me that these calls need to explicitly be done by the typing command machinery.
> > 
> > If I understand the code correctly, respondToChangedSelection() is called on every text insertion. However the behavior we want (which is consistent with AppKit) is clearing the markers only when a line break is inserted.
> 
> Why do we want this behavior on all platforms?  If you're trying to match WebKit's behavior with AppKit, shouldn't we just doing that for Mac platforms?  Also, I'm not even sure clearing markers only when a line break is inserted is an obvious improvement on Mac.

This is in effect Mac only, since on non-Mac platform, the said marker doesn't get added  in the first place. However, I can certainly bracket the removal code with ifdef's if it's desirable.

The goal of this patch is to bring WebKit into parity with other UI on Mac. To further improve this design is probably outside of the scope of this patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.