[Webkit-unassigned] [Bug 45709] Need to remove autocorrection underlines in current line when newline is entered.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45709





--- Comment #9 from jpu at apple.com  2010-09-16 13:46:11 PST ---
(In reply to comment #8)
> (From update of attachment 67822 [details])
> > +        * editing/TypingCommand.cpp:
> > +        (WebCore::TypingCommand::insertLineBreak): Remove "CorrectionUIIndication" markers when a line
> > +          break is inserted.
> > +        (WebCore::TypingCommand::insertParagraphSeparatorInQuotedContent): Remove "CorrectionUIIndication"
> > +          markers when a paragraph separator is inserted.
> > +        (WebCore::TypingCommand::insertParagraphSeparator): Ditto.
> 
> Won’t the call in respondToChangedSelection already take care of this? It doesn’t make sense to me that these calls need to explicitly be done by the typing command machinery.

If I understand the code correctly, respondToChangedSelection() is called on every text insertion. However the behavior we want (which is consistent with AppKit) is clearing the markers only when a line break is inserted. 

That said, please let me know if this can be done in respondToChangedSelection().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.