[Webkit-unassigned] [Bug 39102] [GTK] eventSender.contextClick() should return the contents of the context menu

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39102





--- Comment #9 from Martin Robinson <mrobinson at webkit.org>  2010-09-16 08:32:01 PST ---
(From update of attachment 67774)
View in context: https://bugs.webkit.org/attachment.cgi?id=67774&action=prettypatch

Thank you, thank you, thank you for implementing this missing DRT feature. I just have a few small issues.

> WebKit/gtk/webkit/webkitwebview.cpp:4812
> +    g_return_val_if_fail(WEBKIT_IS_WEB_VIEW(webView), NULL);

This should be a 0.

> WebKit/gtk/webkit/webkitwebview.cpp:4817
> +    ContextMenu* menu = menuController->contextMenu();

I think it will be a lot cleaner to not cache these: ContextMenu* menu = page(webView)->menuController();

> WebKit/gtk/webkit/webkitwebview.cpp:4822
> +    return NULL;

This should be a 0.

> WebKitTools/DumpRenderTree/gtk/EventSender.cpp:154
> +        return JSObjectMakeArray(context, 0, NULL, NULL);

These should be 0 per the style guidelines.

> WebKitTools/DumpRenderTree/gtk/EventSender.cpp:162
> +    if (gtkMenu) {

I think this deserves to be it's own function. We can use an early return that way as well.

> WebKitTools/DumpRenderTree/gtk/EventSender.cpp:167
> +            gchar* label;

I think we should use CString here, if we can. If not GOwnPtr.

> WebKitTools/DumpRenderTree/gtk/EventSender.cpp:178
> +            valueRef = JSObjectMakeArray(context, index - 1, arrayValues, NULL);

Also should be 0.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.