[Webkit-unassigned] [Bug 45408] Include detailed test modifiers (e.g. FLAKY) in results.json for non-layout tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 16 00:37:55 PDT 2010


--- Comment #4 from Kinuko Yasuda <kinuko at chromium.org>  2010-09-16 00:37:55 PST ---
Sorry it took for me so long to update this again.

Basically mostly same with the previous patch, except that I changed how to record FIXABLE_COUNT.
Now it records 'F' for tests with FAILS modifier, 'X' for disabled tests, 'L' for tests with FLAKY modifier and 'P' for others.  (In an assumption that the number of FAILS_ tests is the one we should focus on to  reduce failures - as we discussed.)

(In reply to comment #2)
> (From update of attachment 66935 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=66935&action=prettypatch
> > WebKitTools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:64
> > +            # Shouldn't happen
> If this shouldn't happen, lets just leave out the try/except clause. Otherwise, if this starts happening, we'll never know. I'd be OK with the try/except clause if we logged the error (i.e. a warning level log). But, we shouldn't just silently ignore it.

Added logging.warn in the except part.

> > WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:820
> >                                     individual_test_timings)
> Indentation is off by a space.


Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list