[Webkit-unassigned] [Bug 45599] [Cairo] Generalize ContextShadow from the Qt port and use it for shadow code

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 15 20:05:42 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=45599


WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit.review.bot at gmail.com




--- Comment #6 from WebKit Review Bot <webkit.review.bot at gmail.com>  2010-09-15 20:05:41 PST ---
Attachment 67766 did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/platform/graphics/cairo/CairoUtilities.h:29:  cairo_t is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/graphics/ContextShadow.h:37:  cairo_t is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/graphics/ContextShadow.h:38:  cairo_surface_t is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 3 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list