[Webkit-unassigned] [Bug 45369] Need to check the target frame and restore the right gesture state during the asynchronous history navigation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45369


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67396|review?                     |review+
               Flag|                            |




--- Comment #7 from Adam Barth <abarth at webkit.org>  2010-09-15 17:57:03 PST ---
(From update of attachment 67396)
View in context: https://bugs.webkit.org/attachment.cgi?id=67396&action=prettypatch

> WebCore/loader/RedirectScheduler.cpp:355
> +        // History reload uses the base target as target frame.
> +        Frame* targetFrame = m_frame->tree()->find(m_frame->document()->baseTarget());
> +        if (!targetFrame && !DOMWindow::allowPopUp(m_frame) && !isUserGesture)
> +            return;

Is there a race condition where the target frame changes between when the navigation is scheduled and when it fires?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.