[Webkit-unassigned] [Bug 45838] New: Command.tool should not need to be a WebKitPatch subclass

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 15 14:39:56 PDT 2010


           Summary: Command.tool should not need to be a WebKitPatch
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: eric at webkit.org
                CC: abarth at webkit.org, dpranke at chromium.org

Command.tool should not need to be a WebKitPatch subclass

We need to break out a Tool subclass of WebKitPatch so that all the various commands which assume they have a self.tool.bugs, self.tool.scm, etc. can be run using something other than webkit-patch.

This should mostly just be moving code.  Adam started a patch to do this eons ago.

The end goal is to make it simple to create a new Tool, multi-command style or not.

For example, the following should be possible:

class MyTool(MultiCommandTool, Tool):

if __name__ == "__main__":

We'd probably need to teach it things about what directory to search for commands in, or how to give it a specific set of commands.  We also eventually want to make it easy to create single-command tools.  The MultiCommandTool argument-parsing and command calling logic should just be a mix-in.  Tool is all the data storage.

Command.tool needs to be a "Tool" but does not need to be a MultiCommandTool.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list