[Webkit-unassigned] [Bug 45573] [chromium] Fix incorrect drag node/selection painting.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45573


Daniel Cheng <dcheng at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67716|                            |commit-queue?
               Flag|                            |




--- Comment #6 from Daniel Cheng <dcheng at chromium.org>  2010-09-15 14:28:32 PST ---
(From update of attachment 67716)
(In reply to comment #3)
> I still don't understand what exact semantics you are going for here, so it's hard to judge whether the code does what you want.  Where are the tests for this?

There are no tests. The problem is ScrollView::paint() seemed to be clipping as if the page was never scrolled down.

(In reply to comment #4)
> (From update of attachment 67260 [details])
> I think this will do the wrong thing with iframes and compositing. Iframes pull the paint behavior flags from their parent iframe (see -[WebFrame _drawRect:] in WebKit.
> 
> Rather than paint via the RenderLayer, why not call m_view->paintContents, which does not intersect with the scrollview's frame?
> 

I didn't know about this function. I've updated the patch.

> It would also be nice to share more code here with Mac's Frame::imageFromRect().

I based the implementation of these two functions off of Frame::imageFromRect(). However, they seemed to have a lot of Cocoa-specific magic, so I'm not sure how I could share any more code. Ideas are welcome.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.