[Webkit-unassigned] [Bug 41292] [V8]When a NPAPI plugin calls NPN_Evaluate to execute script in browser, if the call is initiated by user, allow the popup

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=41292


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67689|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #37 from Adam Barth <abarth at webkit.org>  2010-09-15 12:46:51 PST ---
(From update of attachment 67689)
View in context: https://bugs.webkit.org/attachment.cgi?id=67689&action=prettypatch

This looks good to me, but I'm not an expert on the plugin code.  Might be worth having a plug-in expert take a look too.

> WebCore/bindings/v8/NPV8Object.cpp:285
> +    ASSERT(frame);
This assert seems unneeded.  We'll crash on the next line anyway.

> WebKit/mac/ChangeLog:9
> +        execution frame, so WeKit can always get right gesture state on Mac.
WeKit -> WebKit

> WebKit/mac/ChangeLog:10
> +        From Mac Snow Leopard, the plugin is run under "WebKitPluginHost,app"
.app ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.