[Webkit-unassigned] [Bug 44329] SH4 JIT SUPPORT

Wed Sep 15 10:13:32 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=44329

--- Comment #7 from Gabor Loki <loki at webkit.org>  2010-09-15 10:13:32 PST ---
> Created an attachment (id=67675)
 --> (https://bugs.webkit.org/attachment.cgi?id=67675) [details]

Hmmm, you have implemented your own constant/literal pool for SH4. Why? Is the AssemblerBufferWithConstantPool is not sufficent for SH4?

As I see you follow a very similar way to attach the data and pointers into the instruction stream as we have done in AssemblerBufferWithConstantPool. At first sight I did not see any reason why the SH4 should have its own pool implementation. I suggest you try to use the AssemblerBufferWithConstantPool interface for SH4. If you have any problem or question about the interface, you can contact me at IRC.

In addition, I agree with Patrick about the style issue:
- use static const ints, enums and inline functions instead of macros
- fix tabs, unnecessary parenthesis and other trivial style errors which are reported by the check-webkit-style script.

One more question:
What was the problem with the generatePatternCharacterPair function? Why do you have to read a simple character? (I am not familiar with the SH4 architecture)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.