[Webkit-unassigned] [Bug 45021] [GTK] enhanced context menu for media elements

Wed Sep 15 06:26:19 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=45021

--- Comment #9 from Philippe Normand <pnormand at igalia.com>  2010-09-15 06:26:19 PST ---
Thanks for the review Eric!

I applied the changes requested in my branch.

About the fullscreen/save menus I think it depends on the UI design guidelines of the platform.

For instance the GNOME HIG recommends to show the items but make them inactive: http://library.gnome.org/devel/hig-book/stable/menus-design.html.en#menu-item-type-command

I think this is what I'll do... On mac it would probably be different, I don't know.

I will open a separate bug report for supportsSave, this patch is already quite big.

Also I'll wait the bug 39102 gets reviewed to land this patch ;)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.