[Webkit-unassigned] [Bug 45344] Null deref in InlineBox::height()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45344


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #66917|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #6 from Eric Seidel <eric at webkit.org>  2010-09-15 00:01:36 PST ---
(From update of attachment 66917)
View in context: https://bugs.webkit.org/attachment.cgi?id=66917&action=prettypatch

> WebCore/rendering/InlineBox.cpp:-97
> +    if (!renderer()->style(m_firstLine))
> +        return 0;
>      if (renderer()->isText())
>          return m_isText ? renderer()->style(m_firstLine)->font().height() : 0;
> -    if (renderer()->isBox() && parent())
I believe style(m_firstLine) is non-trivial.  Shouldn't we cache it in a local variable?

    RenderStyle* firstLineStyle() const { return document()->usesFirstLineRules() ? firstLineStyleSlowCase() : style(); }
    RenderStyle* style(bool firstLine) const { return firstLine ? firstLineStyle() : style(); }

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.