[Webkit-unassigned] [Bug 44292] Add more instances of Windows EWS

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44292





--- Comment #4 from Eric Seidel <eric at webkit.org>  2010-09-14 22:48:39 PST ---
(In reply to comment #3)
> (In reply to comment #2)
> > The commit-queue just learned how to have more instances as part of bug 45786, moving us one step closer to making this a reality.
> 
> What is left?

The EWS systems use a different mechanism for figuring out what patch to run.

All queues use "next_work_item" to get the next patch:
http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/tool/commands/queues.py#L103

However the EWS (through AbstractiReviewQueue) overrides this to use PatchCollection:
http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/tool/commands/queues.py#L399

The commit-queue on the other hand, round trips through the server:
http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/tool/commands/queues.py#L192
(or is about to after the patch on bug 45786).

We need to teach the EWS how to round trip through the server, and may need to improve the server side code to avoid race conditions between clients.  RIght now there are race conditions in the logic I added with bug 45786, but for the commit-queue it doesn't really matter.

Eventually the plan is to separate out the bugzilla polling from the EWS queue into some sort of "feeder" queue, whereby which all of the EWS bots just read their next patch from the status server (instead of reading all the patches from bugzilla and then informing the status server).  That would greatly reduce the load on bugzilla.  We haven't done it yet because at the current 2 minute poll time for the EWS bots the bugzilla load is tiny (at least according to wms).  Eventually we'd like to have a single queue whose job it is to poll bugzilla and tell all the other queues what they're next to do.  But that may be a yak we shave after implementing some simple server-side mediation between multiple bots, just like I did in bug 45786 for the commit-queue.

I'll look at solving this tomorrow.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.