[Webkit-unassigned] [Bug 45785] Remove WKBundleNodeRef, replacing uses with WKBundleNodeHandleRef.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45785


Anders Carlsson <andersca at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67614|review?                     |review+
               Flag|                            |




--- Comment #2 from Anders Carlsson <andersca at apple.com>  2010-09-14 15:45:04 PST ---
(From update of attachment 67614)
> Index: WebKitTools/ChangeLog
> ===================================================================
> --- WebKitTools/ChangeLog	(revision 67503)
> +++ WebKitTools/ChangeLog	(working copy)
> @@ -1,3 +1,28 @@
> +2010-09-14  Sam Weinig  <sam at webkit.org>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Remove WKBundleNodeRef, replacing uses with WKBundleNodeHandleRef.
> +        https://bugs.webkit.org/show_bug.cgi?id=45785
> +
> +        * MiniBrowser/mac/AppDelegate.m:
> +        (-[BrowserAppDelegate init]):

I don't think you intended to add this.

> Index: WebKitTools/MiniBrowser/mac/AppDelegate.m
> ===================================================================
> --- WebKitTools/MiniBrowser/mac/AppDelegate.m	(revision 67475)
> +++ WebKitTools/MiniBrowser/mac/AppDelegate.m	(working copy)
> @@ -32,7 +32,7 @@
>  #import <WebKit2/WKStringCF.h>
>  #import <WebKit2/WKURLCF.h>
>  
> -static NSString *defaultURL = @"http://www.webkit.org/";
> +static NSString *defaultURL = @"http://www.tivofaq.com/";
>  
>  @implementation BrowserAppDelegate
>  
> @@ -113,10 +113,7 @@ - (id)init
>  {
>      self = [super init];
>      if (self) {
> -        if ([NSEvent modifierFlags] & NSShiftKeyMask)
> -            currentProcessModel = kProcessModelSharedSecondaryThread;
> -        else
> -            currentProcessModel = kProcessModelSharedSecondaryProcess;
> +        currentProcessModel = kProcessModelSharedSecondaryThread;
>  
>          WKContextRef threadContext = WKContextGetSharedThreadContext();
>          WKContextHistoryClient historyClient = {

Or this. Looks fine otherwise!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.